New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negotiation should support async results #347

Closed
cescoffier opened this Issue Sep 12, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@cescoffier
Member

cescoffier commented Sep 12, 2014

Right now negotiation methods only support results. They should also support Async Results such as in:

@Route(method = HttpMethod.GET, uri = "/negotiation/accept")
public Result negotiation() {
    return Negotiation.accept(
            ImmutableMap.of(
                    MimeTypes.JSON, async( () -> ok("{\"message\":\"hello\"}").json(); ),
                    MimeTypes.HTML, async( () -> ok("<h1>Hello</h1>").html(); )
            )
    );
}

@cescoffier cescoffier added this to the 0.7 milestone Sep 12, 2014

@cescoffier cescoffier self-assigned this Sep 12, 2014

cescoffier added a commit that referenced this issue Sep 12, 2014

Apply fix for #347 in the vertx engine
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

@cescoffier cescoffier modified the milestones: 0.7, 0.6.4 Sep 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment