New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how wrapped mojos are invoked #434

Closed
cescoffier opened this Issue Feb 9, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@cescoffier
Member

cescoffier commented Feb 9, 2015

In the current code base, wrapped mojo (mainly the maven-compiler-plugin) configurations are extracted from the pom.xml file. When the configuration is not given, one is generated. However, when one is given it is used as it is. This can be an issue if the configuration contains value for several goals (such as compile and test-compile. As said on #430, it does not work.

The initial idea was to create a separated configurations for each goal:

<plugin>
    <artifactId>maven-compiler-plugin</artifactId>
    <executions>
        <execution>
            <id>default-testCompile</id>
            <goals>
                <goal>testCompile</goal>
            </goals>
            <configuration>
                <testSource>1.8</testSource>
                <testTarget>1.8</testTarget>
            </configuration>
        </execution>
    </executions>
    <configuration>
        <source>1.8</source>
        <target>1.8</target>
    </configuration>
</plugin>

However this is not convenient, and the regular Maven way should be supported.

@cescoffier cescoffier self-assigned this Feb 9, 2015

@cescoffier cescoffier added this to the 0.7.1 milestone Feb 9, 2015

@cescoffier cescoffier closed this in 5aec349 Feb 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment