how to tell wisdom to not filter files inside conf dir #445

Closed
hboumedane opened this Issue Feb 18, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@hboumedane

Hello,
I have a jks file inside my conf directory , when i run wisdom the file is modified even when i use this :

                    <nonFilteredExtensions>
                        <extension>jks</extension>
                    </nonFilteredExtensions>

so , how to prevent this from happening ??

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 18, 2015

Member

Could you tell me which version of the wisdom plugin you are using and
where did you put the configuration. Check that the file has the .jks
extenstion (case matters here).

2015-02-18 15:51 GMT+01:00 hboumedane notifications@github.com:

Hello,
I have a jks file inside my conf directory , when i run wisdom the file is
modified even when i use this :

                <nonFilteredExtensions>
                    <extension>jks</extension>
                </nonFilteredExtensions>

so , how to prevent this from happening ??


Reply to this email directly or view it on GitHub
#445.

Member

cescoffier commented Feb 18, 2015

Could you tell me which version of the wisdom plugin you are using and
where did you put the configuration. Check that the file has the .jks
extenstion (case matters here).

2015-02-18 15:51 GMT+01:00 hboumedane notifications@github.com:

Hello,
I have a jks file inside my conf directory , when i run wisdom the file is
modified even when i use this :

                <nonFilteredExtensions>
                    <extension>jks</extension>
                </nonFilteredExtensions>

so , how to prevent this from happening ??


Reply to this email directly or view it on GitHub
#445.

@hboumedane

This comment has been minimized.

Show comment
Hide comment
@hboumedane

hboumedane Feb 18, 2015

i'm using 0.7.0 wisdom plugin version and yes my file nameis : keystore.jks

i put this config like that :

            <plugin>
                <groupId>org.wisdom-framework</groupId>
                <artifactId>wisdom-maven-plugin</artifactId>
                <version>0.7.0</version>
                <extensions>true</extensions>
                <configuration>
                    <nonFilteredExtensions>
                        <extension>jks</extension>
                    </nonFilteredExtensions>
                </configuration>
            </plugin>

i'm using 0.7.0 wisdom plugin version and yes my file nameis : keystore.jks

i put this config like that :

            <plugin>
                <groupId>org.wisdom-framework</groupId>
                <artifactId>wisdom-maven-plugin</artifactId>
                <version>0.7.0</version>
                <extensions>true</extensions>
                <configuration>
                    <nonFilteredExtensions>
                        <extension>jks</extension>
                    </nonFilteredExtensions>
                </configuration>
            </plugin>
@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 18, 2015

Member

Seems to be a bug, gonna have a look. It's weird because we have an integration-test about this (as far as I remember).

Member

cescoffier commented Feb 18, 2015

Seems to be a bug, gonna have a look. It's weird because we have an integration-test about this (as far as I remember).

@hboumedane

This comment has been minimized.

Show comment
Hide comment
@hboumedane

hboumedane Feb 18, 2015

you could add definitely the jks extension to NON_FILTERED_EXTENSIONS !!

you could add definitely the jks extension to NON_FILTERED_EXTENSIONS !!

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 18, 2015

Member

Yes, but you should have been able to add it to the non filtered extension list (that's the bug).

Member

cescoffier commented Feb 18, 2015

Yes, but you should have been able to add it to the non filtered extension list (that's the bug).

@hboumedane

This comment has been minimized.

Show comment
Hide comment

indeed..

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 22, 2015

Member

Found the bug, the configuration copy does not retrieve the nonFilteredExtensions parameter.

Member

cescoffier commented Feb 22, 2015

Found the bug, the configuration copy does not retrieve the nonFilteredExtensions parameter.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Feb 22, 2015

Member

Two actions:

  1. Add jks to the list of non-filtered extension
  2. Add support for the nonFilteredExtensions parameter in the configuration copy
Member

cescoffier commented Feb 22, 2015

Two actions:

  1. Add jks to the list of non-filtered extension
  2. Add support for the nonFilteredExtensions parameter in the configuration copy

@cescoffier cescoffier added the bug label Feb 22, 2015

@cescoffier cescoffier added this to the 0.7.1 milestone Feb 22, 2015

@hboumedane

This comment has been minimized.

Show comment
Hide comment

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment