New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAML - Issue when a controller does not have a @Path with a value #484

Closed
jetien opened this Issue Apr 24, 2015 · 13 comments

Comments

Projects
None yet
3 participants
@jetien
Contributor

jetien commented Apr 24, 2015

Hi,
I just add the wisdom-raml extension to projet (plugin and monitor extension) but it seems that the template returned does not load correctly (there is an infinite loader) and the controller.raml returned by the server is not displayed.
Show it on the attached screenshot

wisdom-raml_bug

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

It seems that it freeze because of the "null" parents root. I guess it happens if @path is not specified on the controller. Definitely a bug! Thanks (^^)b

Member

barjo commented Apr 24, 2015

It seems that it freeze because of the "null" parents root. I guess it happens if @path is not specified on the controller. Definitely a bug! Thanks (^^)b

@jetien

This comment has been minimized.

Show comment
Hide comment
@jetien

jetien Apr 24, 2015

Contributor

I just test with default @path on controller but it seems to be the same...

capture d ecran 2015-04-24 a 12 23 56

Contributor

jetien commented Apr 24, 2015

I just test with default @path on controller but it seems to be the same...

capture d ecran 2015-04-24 a 12 23 56

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

I just push a fix that should solve the problem. It needed @path with a value, now in case there is no value or no @ParH I put / by default

Member

barjo commented Apr 24, 2015

I just push a fix that should solve the problem. It needed @path with a value, now in case there is no value or no @ParH I put / by default

@cescoffier cescoffier added the planned label Apr 24, 2015

@cescoffier cescoffier changed the title from wisdom-raml to RAML - Issue when a controller does not have a @Path with a value Apr 24, 2015

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 24, 2015

Member

I've renamed the issue.

Member

cescoffier commented Apr 24, 2015

I've renamed the issue.

@cescoffier cescoffier added in progress and removed planned labels Apr 24, 2015

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

@jetien seems there is an other problem in addition to the path, I am not sure exactly why the api-console have problem. Can you try to put a small comment before the '@author' tag in the TestController class javadoc. The '@author' may mess up there js parser, am not sure but that worth a try.

Member

barjo commented Apr 24, 2015

@jetien seems there is an other problem in addition to the path, I am not sure exactly why the api-console have problem. Can you try to put a small comment before the '@author' tag in the TestController class javadoc. The '@author' may mess up there js parser, am not sure but that worth a try.

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

I try with the @author, that's not the problem :-?

Member

barjo commented Apr 24, 2015

I try with the @author, that's not the problem :-?

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

@jetien Ah, one last thing, if you have fix the base url, can you put it to http://localhost:9000/ with the '/' at the end. That may be the issue here.

Member

barjo commented Apr 24, 2015

@jetien Ah, one last thing, if you have fix the base url, can you put it to http://localhost:9000/ with the '/' at the end. That may be the issue here.

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

Actually, that should be alright since the path of your controller will be appended to the base url, but I can see in your raml file, that it didn't occured. I will try to reproduce

Member

barjo commented Apr 24, 2015

Actually, that should be alright since the path of your controller will be appended to the base url, but I can see in your raml file, that it didn't occured. I will try to reproduce

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 24, 2015

Member

Ah I reproduce it. It is still linked to the Controller '@path' annotation. It must start with a '/'

Member

barjo commented Apr 24, 2015

Ah I reproduce it. It is still linked to the Controller '@path' annotation. It must start with a '/'

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Apr 26, 2015

Member

Any fix ?

Member

cescoffier commented Apr 26, 2015

Any fix ?

@cescoffier cescoffier added this to the 0.8.1 milestone Apr 26, 2015

@cescoffier cescoffier added the bug label Apr 26, 2015

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 26, 2015

Member

bb42eb9 fix the missing @Path issue.

Member

barjo commented Apr 26, 2015

bb42eb9 fix the missing @Path issue.

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Apr 26, 2015

Member

@jetien I create an other issue related to the infinite loading -> #487

Member

barjo commented Apr 26, 2015

@jetien I create an other issue related to the infinite loading -> #487

@barjo barjo closed this Apr 26, 2015

@barjo barjo removed the in progress label Apr 26, 2015

@jetien

This comment has been minimized.

Show comment
Hide comment
@jetien

jetien Apr 27, 2015

Contributor

Hi,

ok thanks I'll try it just now

2015-04-26 14:57 GMT+02:00 Jonathan Bardin notifications@github.com:

@jetien https://github.com/jetien I create an other issue related to
the infinite loading -> #487
#487


Reply to this email directly or view it on GitHub
#484 (comment)
.

Julien ETIEN | Ingénieur Etudes et Développement
1 rue Fleming - Bureau 11 - 17000 La Rochelle
+33 (0)5 16 49 04 84 | +33 (0)6 07 88 76 72
website : www.ubidreams.com
Skype : julien.etien

Contributor

jetien commented Apr 27, 2015

Hi,

ok thanks I'll try it just now

2015-04-26 14:57 GMT+02:00 Jonathan Bardin notifications@github.com:

@jetien https://github.com/jetien I create an other issue related to
the infinite loading -> #487
#487


Reply to this email directly or view it on GitHub
#484 (comment)
.

Julien ETIEN | Ingénieur Etudes et Développement
1 rue Fleming - Bureau 11 - 17000 La Rochelle
+33 (0)5 16 49 04 84 | +33 (0)6 07 88 76 72
website : www.ubidreams.com
Skype : julien.etien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment