New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request body truncated when it exceed "request.body.max.size" #535

Closed
nicolas-rempulski opened this Issue Oct 23, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@nicolas-rempulski
Member

nicolas-rempulski commented Oct 23, 2015

I ran into an issue regarding requests body size.

Due to request.body.max.size Wisdom may receive a truncated request.
If the request body size exceed this threshold, extra content is discarded and the request is still handled by Wisdom as everything went fine.

I think if the request exceed the body size limit, Wisdom should immediatly return a Bad Request "Body size exceeding configuration limit" or throw some kind of exception.

@cescoffier cescoffier added this to the 0.10.0 milestone Oct 24, 2015

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Oct 25, 2015

Member

I think a "413 - Body size exceeded" message would be ok. (yes there is a status code for this).

Member

cescoffier commented Oct 25, 2015

I think a "413 - Body size exceeded" message would be ok. (yes there is a status code for this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment