New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpMethod.PATCH should be added #75

Closed
tleveque opened this Issue Jan 23, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@tleveque

No description provided.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Jan 24, 2014

Member

Do you mean supporting PATCH request, or really implementing the exact HTTP behavior of PATCH ?

Member

cescoffier commented Jan 24, 2014

Do you mean supporting PATCH request, or really implementing the exact HTTP behavior of PATCH ?

@barjo

This comment has been minimized.

Show comment
Hide comment
@barjo

barjo Jan 24, 2014

Member

I would got for just supporting the PATCH request, adding it to the API. The behavior somehow is too much related to the business logic, just like PUT is.

Member

barjo commented Jan 24, 2014

I would got for just supporting the PATCH request, adding it to the API. The behavior somehow is too much related to the business logic, just like PUT is.

@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Jan 24, 2014

Member

Ok, so it's quite simple.

Sent from my iPhone

On 24 janv. 2014, at 15:52, Jonathan Bardin notifications@github.com
wrote:

I would got for just supporting the PATCH request, adding it to the API.
The behavior somehow is too much related to the business logic, just like
PUT is.


Reply to this email directly or view it on
GitHubhttps://github.com/wisdom-framework/wisdom/issues/75#issuecomment-33228378
.

Member

cescoffier commented Jan 24, 2014

Ok, so it's quite simple.

Sent from my iPhone

On 24 janv. 2014, at 15:52, Jonathan Bardin notifications@github.com
wrote:

I would got for just supporting the PATCH request, adding it to the API.
The behavior somehow is too much related to the business logic, just like
PUT is.


Reply to this email directly or view it on
GitHubhttps://github.com/wisdom-framework/wisdom/issues/75#issuecomment-33228378
.

cescoffier added a commit that referenced this issue Jan 24, 2014

Fix issue #75
Add the PATCH method

Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>

@cescoffier cescoffier closed this Jan 25, 2014

@cescoffier cescoffier added this to the 0.4.0 milestone Apr 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment