New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt reduction #76

Merged
merged 39 commits into from Jan 24, 2014

Conversation

Projects
None yet
2 participants
@nicolas-rempulski
Member

nicolas-rempulski commented Jan 24, 2014

A.K.A
"If Sonar made my paycheck I would be : "
Debug All The Things

nicolas-rempulski added some commits Jan 23, 2014

[majors]
* At most one statement is allowed per line, but 2 statements were found on this line.
* Missing curly brace.
[Major] The Cyclomatic Complexity of this method "equals" is 12 which…
… is greater than 10 authorized.

* Not so sure about this one
[major] 15 more branches need to be covered by unit tests to reach th…
…e minimum threshold of 65.0% branch coverage.
[majors]
* Add a private constructor to hide the implicit public one.
* Loggers should be "private static final" and should share a naming convention
* Replace this lower case "l" long suffix by an upper case "L"
[majors]
* Move this closing curly brace to the next line.
* Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
* Remove those useless parentheses.
[majors]
* Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
* Move this closing curly brace to the next line.
* Reliance on default encoding
* Switch statements should end with a default case
* Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'
* Remove this empty statement
* Move this closing curly brace to the next line
[majors]
* Rename "listeners" which hides the field declared at line 40.
* Make the "LOGGER" logger private static final
[majors]
* Resource leak: 'jar' is never
 closed
* Utility classes should not have a public constructor
* This block of commented-out lines of code should be removed.
* Reduce the number of conditional operators (8) used in the expression (maximum allowed 3).
* Move the "test" string literal on the left side of this string comparison.
*
[majors + minor]
*Rename this field name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
* Make this final field static too.
* The class name org.wisdom.configuration.ApplicationConfiguration shadows the simple name of implemented interface org.wisdom.api.configuration.ApplicationConfiguration
* Make the "logger" logger private static final and rename it to comply with the format "LOG(?:GER)?".
* Constructor Calls Overridable Method
* Rename "mode" which hides the field declared at line 29.
* Define a constant instead of duplicating this literal "application.mode" 2 times.
* Either log or rethrow this exception along with some contextual information.
[majors]
* Avoid unused private fields such as 'router'.
* Move this closing curly brace to the next line.
* Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
[majors]
* Add a default case to this switch.
* At most one statement is allowed per line, but 2 statements were found on this line.
* Missing curly brace.
* No need to check for null before an instanceof
[majors]
* Make the "logger" logger private static final and rename it to comply with the format "LOG(?:GER)?".
* Merge this if statement with the enclosing one.
* Replace this lower case "l" long suffix by an upper case "L".
* Move the "0" string literal on the left side of this string comparison.
* This block of commented-out lines of code should be removed.
[majors]
* Rename this field name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
* Make this class field a static final constant or non-public and provide accessors if needed.
[majors]
* Add a private constructor to hide the implicit public one.
* Missing curly brace.
* Add a default case to this switch.
* Merge this if statement with the enclosing one.
[majors]
* Found reliance on default encoding
* Missing curly brace.
* At most one statement is allowed per line, but 2 statements were found on this line.
[majors]
* Make the "logger" logger private static final and rename it to comply with the format "LOG(?:GER)?".
* Move the "" string literal on the left side of this string comparison.
* String.indexOf(char) is faster than String.indexOf(String).
* Remove those useless parentheses.
[majors]
* Make the "LOGGER" logger private static final.
* Merge this if statement with the enclosing one.
[majors]
* Make this class field a static final constant or non-public and provide accessors if needed.
* Return an empty collection instead of null.
* Rename "arguments" which hides the field declared at line 27.
[majors]
* Avoid unused constructor parameters such as 'resp'.
* Merge this if statement with the enclosing one.
* Return an empty collection instead of null.
[majors]
* Make the "logger" logger private static final and rename it to comply with the format "LOG(?:GER)?".
* Remove those useless parentheses.
* Use isEmpty() to check whether the collection is empty or not.
[majors]
* Add a default case to this switch.
* Rename "interceptors" which hides the field declared at line 34.
[majors]
* The type of the "chain" object should be an interface such as "List" rather than the implementation "LinkedList".
* The type of the "interceptors" object should be an interface such as "Map" rather than the implementation "LinkedHashMap".
* The type of the "interceptors" object should be an interface such as "Map" rather than the implementation "LinkedHashMap".
[majors]
* Make this class field a static final constant or non-public and provide accessors if needed.
* org.wisdom.test.parents.WisdomTest.mapper isn't final but should be
*
@cescoffier

This comment has been minimized.

Show comment
Hide comment
@cescoffier

cescoffier Jan 24, 2014

Member

OMG ! That's a PR !

Member

cescoffier commented Jan 24, 2014

OMG ! That's a PR !

cescoffier added a commit that referenced this pull request Jan 24, 2014

@cescoffier cescoffier merged commit 64c207f into master Jan 24, 2014

@cescoffier cescoffier deleted the td-reduction branch Jan 24, 2014

@cescoffier cescoffier added this to the 0.4.0 milestone Apr 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment