New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No information if post was already voted #13

Closed
lukmarcus opened this Issue Jun 24, 2018 · 5 comments

Comments

3 participants
@lukmarcus

lukmarcus commented Jun 24, 2018

There should be an information if delegator has already voted for post from link. This could happen after url paste or after validate.

@noisy noisy added the enhancement label Jun 25, 2018

@lukmarcus

This comment has been minimized.

lukmarcus commented Jun 25, 2018

This should be listed as bug. With 2nd/3rd etc. vote you can change height of previous upvotes:

Voting AGAIN should be possible only with bigger vote power and still there should be information after validate like this post was already voted by voter X with Y% of delegate Z.

@jakipatryk

This comment has been minimized.

Contributor

jakipatryk commented Jun 25, 2018

@lukmarcus Does re-vote consume voting power? I'm sure it cancels curation reward tho, so it's not good for delegator anyway.

I'm not sure if this is frontend issue at all, maybe this problem should be fixed in the core library?

On the other hand, the voter might want to downvote a post that has already been upvoted by a delegator, because he/she found the post a plagiarism or something.

I can work on this issue.

@lukmarcus

This comment has been minimized.

lukmarcus commented Jun 25, 2018

@jakipatryk

Does re-vote consume voting power?

Lower vote didn't consume power. I didn't check it for higher vote - but it looked like only percent difference was taken from account.

the voter might want to downvote a post

It's not as easy as it sounds because it works two ways - you can flag a vote or vote a flag. I forgot about that. So... Can voter change vote power? If yes, we must answer some questions:

  1. Can voter change a vote/flag from delegator?
  2. Can vote/flag be changed up, down or both?
  3. Can vote be changed into flag and the other way?

Maybe there should be something like hierarchy of voters? So one voter can only change something from below and not above?

@jakipatryk

This comment has been minimized.

Contributor

jakipatryk commented Jun 25, 2018

I think a hierarchy of voters might be a bit too complicated at this point. IMO overwriting a vote should be disabled by default, but there should be a rule (or rules?) to let delegator enable it for certain voters, example rule could look like this:

{
    "rule": "overwrite_vote",
    "mode": "decrease_vote_weight", // or "increase_vote_weight", or "both", determines whether voter can increase a vote weight, decrease, or do both
    "when": "is_downvote" // or "is_upvote", or "is_any", determines when voter can overwrite a vote (when it's upvote, when it's downvote, or when it's either of them
    "times": "once" // or "twice", or "any", determines how many times a voter can overwrite a vote on one single post, I'm not sure if it's needed tho
}

What do you think? @lukmarcus

@lukmarcus

This comment has been minimized.

lukmarcus commented Jun 25, 2018

It's a nice solution. I like it.

But still going back to first problem - there should be an information that post was already voted by delegator.

@noisy noisy added this to Low priority in Wise Jul 4, 2018

@Jblew Jblew closed this in #22 Jul 13, 2018

Wise automation moved this from TODO (Low priority) to Closed Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment