Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 on blog post #604

Closed
wants to merge 6 commits into from
Closed

Conversation

lorenzolewis
Copy link
Contributor

Is this a sign I have too much time on my hands? 😅

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for astro-www-2 failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0c15efd
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/640dd37f7bda820008badba4

@tony-sull
Copy link
Contributor

Oh, thanks for keeping our old blog posts up-to-date @lorenzolewis!

This one should already be handled by a redirect. Are you seeing a 404 in production or in local dev builds?

@lorenzolewis
Copy link
Contributor Author

Ah no problem then. It was on a local build that I was working with, didn't think to check the netlify config. Can confirm it redirects on the live site.

@tony-sull
Copy link
Contributor

Going to close this one out and let the original post fly, really appreciate you taking the time to file a PR for it just in case!

We had to actually revert an update last week that moved our scripts to use Netlify CLI for netlify dev which would have picked up those redirects locally. Time to revisit fixing the issue in that PR so we can improve the local dev experience!

@tony-sull tony-sull closed this Mar 13, 2023
@lorenzolewis
Copy link
Contributor Author

I didn't even realise you could setup the netlify redirects to work locally as well. Do you have a link to that PR I could look at taking some inspiration from for the Tauri website?

@delucis
Copy link
Member

delucis commented Mar 13, 2023

Here you go @lorenzolewis! #572

@lorenzolewis
Copy link
Contributor Author

Thank you! Do you have an issue open or something with a bit context of why it was reverted?

@delucis
Copy link
Member

delucis commented Mar 13, 2023

We realised some of our redirects were no longer working correctly in production. Quick debugging didn’t reveal why, so reverted to be safe (better a broken dev, than a broken prod 😅).

@lorenzolewis
Copy link
Contributor Author

Coolio! I'll pay around with it on our beta site and see if anything wonky happens. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants