Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating our prose styling to Tailwind's components layer #621

Merged
merged 3 commits into from Mar 20, 2023

Conversation

tony-sull
Copy link
Contributor

This fixes (well, dodges) a potential specificity bug where the main Tailwind bundle is added to the page after a component's style

In this case, the reset for p { margin: 0 } was taking precedent over the Prose.astro component's article > * + * { margin: 1.5rem } style

@netlify
Copy link

netlify bot commented Mar 20, 2023

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 52facc6
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6418b7011ded5f00089b2c0a
😎 Deploy Preview https://deploy-preview-621--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@itsMapleLeaf itsMapleLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I kept thinking about doing this myself but never got around to it

@tony-sull tony-sull merged commit 7a28714 into main Mar 20, 2023
6 checks passed
@tony-sull tony-sull deleted the fix/blog-prose-specificity branch March 20, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants