Adjusting prose content to max 70ch wide #623
Conversation
✅ Deploy Preview for astro-www-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -2,8 +2,6 @@ | |||
| export interface Props { | |||
| src: string | |||
| } | |||
|
|
|||
| const { src } = Astro.props as Props | |||
There was a problem hiding this comment.
linter fix: unused variable
| @@ -85,6 +85,11 @@ | |||
| @apply mx-0.5 inline-block rounded-lg bg-astro-gray-500 px-2 align-baseline text-sm leading-6 text-astro-gray-100; | |||
| } | |||
|
|
|||
| .prose :is(h1, h2, h3, h4, h5) > code { | |||
There was a problem hiding this comment.
noticed a styling bug in blog posts with <code> in a heading, font-size and line-height need to be inherited in this case
There was a problem hiding this comment.
LGTM @tony-sull!
I just have this small nit: the Twitter card isn't filling the 70ch width (or being centered). Considering it's an iframe it might not be seamless to change, and not something I'd say is blocking, so I'm fine with leaving this way.
|
@Yan-Thomas Those Twitter embeds are the worst 😅 Their iframe actually breaks responsive layouts in weird ways by reading the rendered width once when it loads and inlining a Consider it a high-priority TODO to replace those any Tweet in our blog with a static representation of the tweet, we don't need all that JS in a blog post! |
Updating the prose styling used in blog posts, theme detail pages, and generic pages like T&Cs and Privacy Policy
Note: I also shrunk the width of blog post cover images slightly, it felt a bit too big to me with the narrower blog post content