Move catch-all redirect to an Astro endpoint #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the redirect was messing with the netlify dev server and breaking live reload, so I added SSR to let astro handle that instead commit config
✅ Deploy Preview for astro-new ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tony-sull
reviewed
Mar 28, 2023
tony-sull
reviewed
Mar 28, 2023
tony-sull
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Looks good! Pretty sure this was originally written before SSR support, nice to have this logic all in the Astro app instead of split between SSG and a custom serverless function 🙌
Added one note related to the config file format in case it fixes the @astrojs/netlify typing issue, but very unimportant and non-blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect was messing with the Netlify dev server and breaking live reload, so I added SSR to let Astro handle that instead