Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new site header #32

Merged
merged 8 commits into from Mar 29, 2023
Merged

Add new site header #32

merged 8 commits into from Mar 29, 2023

Conversation

itsMapleLeaf
Copy link
Contributor

No description provided.

@itsMapleLeaf itsMapleLeaf marked this pull request as ready for review March 28, 2023 16:48
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for astro-new ready!

Name Link
🔨 Latest commit a2b1040
🔍 Latest deploy log https://app.netlify.com/sites/astro-new/deploys/642371b634790400085339db
😎 Deploy Preview https://deploy-preview-32--astro-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-03-28 at 12 16 24 PM

Mobile/tablet doesn't really make much sense here since the site links to web containers, but may be worth a quick mobile layout for the header just so it doesn't overflow - maybe just hide either the astro.new text or the social links?

Base automatically changed from ssr-redirect-route to next March 28, 2023 22:34
@itsMapleLeaf itsMapleLeaf merged commit 2b345c5 into next Mar 29, 2023
6 checks passed
@itsMapleLeaf itsMapleLeaf deleted the header branch March 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants