Fix up Lighthouse issues #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-new ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tony-sull
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a few Lighthouse issues we were seeing in the astro.new redesign.
It can be a bit tricky to run Lighthouse against a Netlify preview deploy because of how they inject the review drawer which is a chonky React app, but turns out you can run against a permalink URL to avoid that, e.g. https://646737a203f50a0008bb59c4--astro-new.netlify.app/latest/
The site should get 99/100/100/100 scores after these changes, which also dropped data transfer by about 100kB thanks to a few resized images.