From 335f7565ace7cf2e9c83ef65850fdf3fb69193b1 Mon Sep 17 00:00:00 2001
From: lilnasy <69170106+lilnasy@users.noreply.github.com>
Date: Sun, 24 Sep 2023 21:08:12 +0000
Subject: [PATCH] add tests

---
 .../custom-404-implicit-rerouting.test.js     | 57 +++++++++++++++++++
 .../custom-404-loop-case-1/astro.config.mjs   |  1 +
 .../custom-404-loop-case-1/package.json       |  8 +++
 .../src/pages/404.astro                       |  4 ++
 .../src/pages/index.astro                     |  1 +
 .../custom-404-loop-case-2/astro.config.mjs   |  1 +
 .../custom-404-loop-case-2/package.json       |  8 +++
 .../src/pages/404.astro                       |  4 ++
 .../src/pages/index.astro                     |  1 +
 .../custom-404-loop-case-3/astro.config.mjs   |  1 +
 .../custom-404-loop-case-3/package.json       |  8 +++
 .../custom-404-loop-case-3/src/middleware.js  |  7 +++
 .../src/pages/404.astro                       |  1 +
 .../src/pages/index.astro                     |  1 +
 .../custom-404-loop-case-4/astro.config.mjs   |  1 +
 .../custom-404-loop-case-4/package.json       |  8 +++
 .../custom-404-loop-case-4/src/middleware.js  |  6 ++
 .../src/pages/404.astro                       |  1 +
 .../src/pages/index.astro                     |  1 +
 pnpm-lock.yaml                                | 24 ++++++++
 20 files changed, 144 insertions(+)
 create mode 100644 packages/astro/test/custom-404-implicit-rerouting.test.js
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-1/astro.config.mjs
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-1/package.json
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/404.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/index.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-2/astro.config.mjs
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-2/package.json
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/404.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/index.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-3/astro.config.mjs
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-3/package.json
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-3/src/middleware.js
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/404.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/index.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-4/astro.config.mjs
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-4/package.json
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-4/src/middleware.js
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/404.astro
 create mode 100644 packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/index.astro

diff --git a/packages/astro/test/custom-404-implicit-rerouting.test.js b/packages/astro/test/custom-404-implicit-rerouting.test.js
new file mode 100644
index 0000000000000..4a5276c861d6a
--- /dev/null
+++ b/packages/astro/test/custom-404-implicit-rerouting.test.js
@@ -0,0 +1,57 @@
+import { expect } from 'chai';
+import { loadFixture } from './test-utils.js';
+
+for (const caseNumber of [ 1, 2, 3, 4 ]) {
+	describe(`Custom 404 with implicit rerouting - Case #${caseNumber}`, () => {
+		/** @type Awaited<ReturnType<typeof loadFixture>> */ 
+		let fixture;
+		/** @type Awaited<ReturnType<typeof fixture['startDevServer']>> */ 
+		let devServer
+	
+		before(async () => {
+			fixture = await loadFixture({
+				root: `./fixtures/custom-404-loop-case-${caseNumber}/`,
+				site: 'http://example.com'
+			});
+	
+			devServer = await fixture.startDevServer();
+		});
+
+		// sanity check
+		it('dev server handles normal requests', async () => {
+			const resPromise = fixture.fetch('/');
+			const result = await withTimeout(resPromise, 1000);
+			expect(result).to.not.equal(timeout);
+			expect(result.status).to.equal(200);
+		});
+
+		it('dev server stays responsive', async () => {
+			const resPromise = fixture.fetch('/alvsibdlvjks');
+			const result = await withTimeout(resPromise, 1000);
+			expect(result).to.not.equal(timeout);
+			expect(result.status).to.equal(404);
+		});
+	
+		after(async () => {
+			await devServer.stop();
+		});
+	});
+}
+
+
+/***** UTILITY FUNCTIONS *****/
+
+const timeout = Symbol("timeout")
+
+/** @template Res */
+function withTimeout(
+	/** @type Promise<Res> */
+	responsePromise,
+	/** @type number */
+	timeLimit
+) {
+	/** @type Promise<typeof timeout> */
+	const timeoutPromise = new Promise(resolve => setTimeout(() => resolve(timeout), timeLimit))
+	
+	return Promise.race([ responsePromise, timeoutPromise ]);
+}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-1/astro.config.mjs b/packages/astro/test/fixtures/custom-404-loop-case-1/astro.config.mjs
new file mode 100644
index 0000000000000..56004c9f9e062
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-1/astro.config.mjs
@@ -0,0 +1 @@
+export default {}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-1/package.json b/packages/astro/test/fixtures/custom-404-loop-case-1/package.json
new file mode 100644
index 0000000000000..cbc4f22ed083c
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-1/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/custom-404-loop-case-1",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/404.astro b/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/404.astro
new file mode 100644
index 0000000000000..ff217453dd8e6
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/404.astro
@@ -0,0 +1,4 @@
+---
+Astro.response.status = 404
+---
+<p>four oh four route</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/index.astro b/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/index.astro
new file mode 100644
index 0000000000000..a65c81fdb2f1f
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-1/src/pages/index.astro
@@ -0,0 +1 @@
+<p>all good here... or is it?</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-2/astro.config.mjs b/packages/astro/test/fixtures/custom-404-loop-case-2/astro.config.mjs
new file mode 100644
index 0000000000000..56004c9f9e062
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-2/astro.config.mjs
@@ -0,0 +1 @@
+export default {}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-2/package.json b/packages/astro/test/fixtures/custom-404-loop-case-2/package.json
new file mode 100644
index 0000000000000..2c5d3be559c88
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-2/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/custom-404-loop-case-2",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/404.astro b/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/404.astro
new file mode 100644
index 0000000000000..0c079adca0408
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/404.astro
@@ -0,0 +1,4 @@
+---
+return new Response(null, { status: 404 })
+---
+<p>four oh four route</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/index.astro b/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/index.astro
new file mode 100644
index 0000000000000..a65c81fdb2f1f
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-2/src/pages/index.astro
@@ -0,0 +1 @@
+<p>all good here... or is it?</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-3/astro.config.mjs b/packages/astro/test/fixtures/custom-404-loop-case-3/astro.config.mjs
new file mode 100644
index 0000000000000..56004c9f9e062
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-3/astro.config.mjs
@@ -0,0 +1 @@
+export default {}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-3/package.json b/packages/astro/test/fixtures/custom-404-loop-case-3/package.json
new file mode 100644
index 0000000000000..51b90b3cb5a47
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-3/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/custom-404-loop-case-3",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-3/src/middleware.js b/packages/astro/test/fixtures/custom-404-loop-case-3/src/middleware.js
new file mode 100644
index 0000000000000..992ca1de8d10c
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-3/src/middleware.js
@@ -0,0 +1,7 @@
+export async function onRequest(ctx, next) {
+    if (ctx.url.pathname !== '/') {
+        const response = await next()
+        return new Response(response.body, { ...response, status: 404 })
+    }
+    return next();
+}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/404.astro b/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/404.astro
new file mode 100644
index 0000000000000..af3c5ef0ae3fe
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/404.astro
@@ -0,0 +1 @@
+<p>four oh four route</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/index.astro b/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/index.astro
new file mode 100644
index 0000000000000..a65c81fdb2f1f
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-3/src/pages/index.astro
@@ -0,0 +1 @@
+<p>all good here... or is it?</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-4/astro.config.mjs b/packages/astro/test/fixtures/custom-404-loop-case-4/astro.config.mjs
new file mode 100644
index 0000000000000..56004c9f9e062
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-4/astro.config.mjs
@@ -0,0 +1 @@
+export default {}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-4/package.json b/packages/astro/test/fixtures/custom-404-loop-case-4/package.json
new file mode 100644
index 0000000000000..0fb69f5139e07
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-4/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@test/custom-404-loop-case-4",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-4/src/middleware.js b/packages/astro/test/fixtures/custom-404-loop-case-4/src/middleware.js
new file mode 100644
index 0000000000000..6ab0cac692797
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-4/src/middleware.js
@@ -0,0 +1,6 @@
+export function onRequest(ctx, next) {
+    if (ctx.url.pathname !== '/') {
+        return new Response(null, { status: 404 });
+    }
+    return next();
+}
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/404.astro b/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/404.astro
new file mode 100644
index 0000000000000..af3c5ef0ae3fe
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/404.astro
@@ -0,0 +1 @@
+<p>four oh four route</p>
\ No newline at end of file
diff --git a/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/index.astro b/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/index.astro
new file mode 100644
index 0000000000000..a65c81fdb2f1f
--- /dev/null
+++ b/packages/astro/test/fixtures/custom-404-loop-case-4/src/pages/index.astro
@@ -0,0 +1 @@
+<p>all good here... or is it?</p>
\ No newline at end of file
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 1aebf6930f4cf..2e02ccdceb1e4 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -2540,6 +2540,30 @@ importers:
         specifier: workspace:*
         version: link:../../..
 
+  packages/astro/test/fixtures/custom-404-loop-case-1:
+    dependencies:
+      astro:
+        specifier: workspace:*
+        version: link:../../..
+
+  packages/astro/test/fixtures/custom-404-loop-case-2:
+    dependencies:
+      astro:
+        specifier: workspace:*
+        version: link:../../..
+
+  packages/astro/test/fixtures/custom-404-loop-case-3:
+    dependencies:
+      astro:
+        specifier: workspace:*
+        version: link:../../..
+
+  packages/astro/test/fixtures/custom-404-loop-case-4:
+    dependencies:
+      astro:
+        specifier: workspace:*
+        version: link:../../..
+
   packages/astro/test/fixtures/custom-404-md:
     dependencies:
       astro: