Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 500.astro improvements #11134

Merged
merged 19 commits into from
Jun 19, 2024
Merged

feat: 500.astro improvements #11134

merged 19 commits into from
Jun 19, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 23, 2024

Changes

Testing

Adds tests to check:

  1. If the custom 500.astro is rendered in dev/preview
  2. If the default error page (error overlay in dev, nothing in preview) is rendered if the custom 500 throws

Docs

withastro/docs#8392

Copy link

changeset-bot bot commented May 23, 2024

🦋 Changeset detected

Latest commit: b4cceb0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels May 23, 2024
@github-actions github-actions bot removed the pkg: example Related to an example package (scope) label May 24, 2024
@florian-lefebvre florian-lefebvre changed the title feat: better error handling feat: 500.astro improvements May 24, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label May 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 24, 2024 11:29
packages/astro/src/core/render-context.ts Outdated Show resolved Hide resolved
packages/astro/src/core/app/index.ts Show resolved Hide resolved
.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
@ematipico ematipico added this to the 4.11.0 milestone Jun 10, 2024
packages/astro/test/custom-500.test.js Outdated Show resolved Hide resolved
packages/astro/src/core/app/index.ts Show resolved Hide resolved
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestions for your consideration here, @florian-lefebvre ! See what you think, and adjust any of them as necessary.

.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!! 🥳

.changeset/rich-dolls-compete.md Show resolved Hide resolved
.changeset/rich-dolls-compete.md Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 9042be0 into main Jun 19, 2024
14 checks passed
@matthewp matthewp deleted the feat/better-error-handling branch June 19, 2024 14:00
@astrobot-houston astrobot-houston mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants