Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #11731
Did a manual revert by hand since there's some good refactors that were made in #11645:
create-astro,@astrojs/db, and@astrojs/upgrade(uses args or yargs-parser)astro(uses args-parser), some non-breaking refactors were kept.parseArgsas they don't affect us as much.Explanation of problem
With our previous option,
parseArgsparse things rather strangely:I also tested enabling
strict: true, but things get sillier sinceparseArgsdoesn't support dual boolean/string arguments. I also feel like it'll cause more problems for the other packages so I reverted them all back. Why can't node design proper APIs :(Testing
Tested manually. The
cli.test.jsshould also pass.Docs
n/a. bug fix.