feat(next): better tsconfig #11859
feat(next): better tsconfig #11859
Conversation
🦋 Changeset detectedLatest commit: b2d1ea0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: example
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Not quite the same, eh? 😅 Left you some thoughts!
There was a problem hiding this comment.
We have moved the adapter to https://github.com/withastro/adapters, so this PR can't be merged here anymore.
I would offer to port over the changes to the new repo for you, just let me know if you want me to do that.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…tro-project/src/env.d.ts
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
A couple of tiny comments, but in general, I approve the changeset and trust whatever decisions you make are fine! 💪
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
florian-lefebvre
dismissed
github-actions[bot]’s stale review
I know what I'm doing
Changes
env.d.tsanymore, recommend using tsconfig (see docs PR)Testing
sync test updated
Docs
withastro/docs#9218