Skip to content

feat(fonts): merge families - #14750

Merged
florian-lefebvre merged 9 commits into
mainfrom
feat/fonts-merge-families
Nov 12, 2025
Merged

florian-lefebvre merged 9 commits into
mainfrom
feat/fonts-merge-families

Conversation

@florian-lefebvre

@florian-lefebvre florian-lefebvre commented Nov 11, 2025 •

Copy link
Copy Markdown
Member

Changes

  • Feedback from Discord
  • Before, it was not possible to only download font files for weights normal 500, italic 500 and normal 600. This is because a font family is defined by a combination of weights and styles, so you'd necessarily have to also download italic 600
  • Now, families that have the same cssVariable, name and provider will be merged
  • This PR also adds a warning log if there are several unmergeable families (same cssVariable but different name/provider)

Testing

Manually tested, unit tests added

Docs

@florian-lefebvre florian-lefebvre self-assigned this Nov 11, 2025
@changeset-bot

changeset-bot Bot commented Nov 11, 2025 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: de30f3c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Nov 11, 2025
@codspeed

codspeed Bot commented Nov 11, 2025 •

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #14750 will not alter performance

Comparing feat/fonts-merge-families (de30f3c) with main (18c55e1)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (72381ef) during the generation of this report, so 18c55e1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@florian-lefebvre
florian-lefebvre marked this pull request as ready for review November 11, 2025 16:28

@ematipico ematipico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just a nit

Comment thread packages/astro/src/assets/fonts/logic/dedupe-font-faces.ts Outdated
@florian-lefebvre
florian-lefebvre merged commit 35122c2 into main Nov 12, 2025
6 checks passed
@florian-lefebvre
florian-lefebvre deleted the feat/fonts-merge-families branch November 12, 2025 17:22
@astrobot-houston astrobot-houston mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants