Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert preact signals support #4843

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Revert preact signals support #4843

merged 3 commits into from
Sep 22, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tests will pass once we merge this.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

⚠️ No Changeset found

Latest commit: 77b6145

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Sep 22, 2022
@matthewp matthewp mentioned this pull request Sep 22, 2022
Merged
tony-sull
tony-sull approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💰

Test failures look unrelated, should be good to merge if they pass on a re-run

@matthewp matthewp merged commit 25a5b9a into main Sep 22, 2022
@matthewp matthewp deleted the revert-preact-signals branch September 22, 2022 14:32
This was referenced Sep 23, 2022
Merged
Closed
matthewp added a commit that referenced this pull request Oct 7, 2022
@matthewp
Revert "Revert preact signals support (#4843)"
b053573 
This reverts commit 25a5b9a.
matthewp added a commit that referenced this pull request Oct 10, 2022
@matthewp
Revert "Revert preact signals support (#4843)" (#5015)
b1964e9 
This reverts commit 25a5b9a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh approved these changes

@tony-sull tony-sull tony-sull approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewp @Princesseuh @tony-sull