Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-layout head injection #8449

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Fix multi-layout head injection #8449

merged 5 commits into from
Sep 8, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Sep 7, 2023

Changes

Testing

  • Updated an existing test case but went deeper to add an extra layer of layout which triggers the need to call renderAstroComponent which is where the bug is.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 3b5bf05

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 7, 2023
@natemoo-re
Copy link
Member

That failing test looks like this change switches the rendering order again... I'm not sure if this is solvable without eagerly evaluating slots, rendering bottom-up rather than top-down.

That being said, there are top-down rendering is something we've really tried to stick with because lazy slot evaluation has some very nice implications for conditional logic. Folks are relying on our current behavior, unfortunately.

@matthewp
Copy link
Contributor Author

matthewp commented Sep 7, 2023

Putting back to draft as I think there's another possible solution here.

@matthewp matthewp marked this pull request as draft September 7, 2023 16:37
@lilnasy
Copy link
Contributor

lilnasy commented Sep 7, 2023

Do you mind if I add some tests. I made some a while ago based on #7761's repro.

@matthewp
Copy link
Contributor Author

matthewp commented Sep 7, 2023

!preview propagation-metadata

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--propagation-metadata" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/internal-helpers:build cache miss, executing �[2m5c0b1e7c443b116c�[0m > @astrojs/internal-helpers@0.2.0 build /home/runner/work/astro/astro/packages/internal-helpers > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/prism:build cache miss, executing �[2md6a81ed3cba41d8b�[0m > @astrojs/prism@3.0.0 build /home/runner/work/astro/astro/packages/astro-prism > astro-scripts build "src/**/*.ts" && tsc -p ./tsconfig.json ::endgroup:: ::group::create-astro:build cache miss, executing �[2m2a90c1c0470c0dd1�[0m > create-astro@4.0.2 build /home/runner/work/astro/astro/packages/create-astro > astro-scripts build "src/index.ts" --bundle && tsc ::endgroup:: ::group::@astrojs/telemetry:build cache miss, executing �[2m6c2eb613a35bd8f9�[0m > @astrojs/telemetry@3.0.1 build /home/runner/work/astro/astro/packages/telemetry > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdown-remark:build cache miss, executing �[2maed83fd4f29cfd40�[0m > @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907173002 build /home/runner/work/astro/astro/packages/markdown/remark > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::astro:build cache miss, executing �[2m4ed597c7e88875f8�[0m > astro@0.0.0-propagation-metadata-20230907173002 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-propagation-metadata-20230907173002 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-propagation-metadata-20230907173002 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2m5ec30809dfef4eaf�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2mfd51a384d196ae6e�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2ma1d88f1e2f64bbf4�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m1ab8f6dc63f7ecd7�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m63406f7a0814281a�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2mf032d1cf127ae98f�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m99f78c4b14d545cd�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2m888849d57c1cc105�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m4d32c1f473d0082e�[0m > @astrojs/mdx@0.0.0-propagation-metadata-20230907173002 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2mcc8ab2e79e42b141�[0m > @astrojs/svelte@4.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2me5dce33f85a02d0c�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2mb67cd188c15bcd7f�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2mfdd7811243894ccd�[0m > @astrojs/react@3.0.1 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2m9b5a499bc6b8d05f�[0m > @astrojs/solid-js@0.0.0-propagation-metadata-20230907173002 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2mb777169266cdadc4�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2meb30579511b47e6c�[0m > @astrojs/vercel@4.0.4 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2mfdff85dd1043d4a8�[0m > @astrojs/cloudflare@7.0.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2mdb8b90b490e6a924�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2mbdf8488a2cd6fa0d�[0m > @astrojs/netlify@3.0.1 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2m0c6eeb6f12f7b0ea�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2mdf6952503fec40b3�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 0 cached, 27 total Time: 1m15.234s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--propagation-metadata tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-propagation-metadata-20230907173002) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/mdx is being published because our local version (0.0.0-propagation-metadata-20230907173002) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/solid-js is being published because our local version (0.0.0-propagation-metadata-20230907173002) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 4.0.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/markdown-remark is being published because our local version (0.0.0-propagation-metadata-20230907173002) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-propagation-metadata-20230907173002"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/mdx"�[39m at �[32m"0.0.0-propagation-metadata-20230907173002"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/solid-js"�[39m at �[32m"0.0.0-propagation-metadata-20230907173002"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/markdown-remark"�[39m at �[32m"0.0.0-propagation-metadata-20230907173002"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-propagation-metadata-20230907173002 🦋 @astrojs/mdx@0.0.0-propagation-metadata-20230907173002 🦋 @astrojs/solid-js@0.0.0-propagation-metadata-20230907173002 🦋 @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907173002 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-propagation-metadata-20230907173002 🦋 New tag: @astrojs/mdx@0.0.0-propagation-metadata-20230907173002 🦋 New tag: @astrojs/solid-js@0.0.0-propagation-metadata-20230907173002 🦋 New tag: @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907173002

@matthewp
Copy link
Contributor Author

matthewp commented Sep 7, 2023

!preview propagation-metadata

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--propagation-metadata" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/prism:build cache hit, suppressing logs �[2md6a81ed3cba41d8b�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache hit, suppressing logs �[2m6c2eb613a35bd8f9�[0m ::endgroup:: ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m5c0b1e7c443b116c�[0m ::endgroup:: ::group::create-astro:build cache hit, suppressing logs �[2m2a90c1c0470c0dd1�[0m ::endgroup:: ::group::@astrojs/markdown-remark:build cache miss, executing �[2mc5005333dea8fc79�[0m > @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907174633 build /home/runner/work/astro/astro/packages/markdown/remark > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::astro:build cache miss, executing �[2m726058a568955f69�[0m > astro@0.0.0-propagation-metadata-20230907174633 build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > astro@0.0.0-propagation-metadata-20230907174633 prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > astro@0.0.0-propagation-metadata-20230907174633 postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2m9a2af5081d328943�[0m > @astrojs/underscore-redirects@0.3.0 build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m7b5d684806f6f660�[0m > @astrojs/tailwind@5.0.0 build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2m9d1bc92d784a8c9b�[0m > @astrojs/lit@3.0.0 build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2m62e8535f7bc8603c�[0m > @astrojs/deno@5.0.0 build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m6115376cd9d04349�[0m > @astrojs/partytown@2.0.0 build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2mdc2c7a91b7a6152d�[0m > @astrojs/rss@3.0.0 build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m1b9571274f685938�[0m > @astrojs/preact@3.0.0 build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2mef033c6c33185c6f�[0m > @astrojs/markdoc@0.5.0 build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2mc79e15f9d8371488�[0m > @astrojs/svelte@4.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2m99d9a651696b6ea1�[0m > @astrojs/vue@3.0.0 build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m2eb34f002baa4c25�[0m > @astrojs/prefetch@0.4.0 build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2m16cdca2c69073d87�[0m > @astrojs/alpinejs@0.3.0 build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2mff02b8212ad4d86f�[0m > @astrojs/solid-js@0.0.0-propagation-metadata-20230907174633 build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2ma26a6e83a245b837�[0m > @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2m0e92e44bf01b2fbc�[0m > @astrojs/vercel@4.0.4 build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2m3c6df69e68653254�[0m > @astrojs/node@6.0.0 build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2mfc5306dc06f41433�[0m > @astrojs/react@3.0.1 build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m74304a9a41e0c502�[0m > @astrojs/mdx@0.0.0-propagation-metadata-20230907174633 build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2mfefd5a1054081121�[0m > @astrojs/netlify@3.0.1 build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2mfb671fdf66936000�[0m > @astrojs/cloudflare@7.0.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2md41a0a2fe7ccc6dc�[0m > @astrojs/sitemap@3.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 4 cached, 27 total Time: 1m11.735s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--propagation-metadata tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-propagation-metadata-20230907174633) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 7.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/mdx is being published because our local version (0.0.0-propagation-metadata-20230907174633) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/solid-js is being published because our local version (0.0.0-propagation-metadata-20230907174633) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 4.0.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/markdown-remark is being published because our local version (0.0.0-propagation-metadata-20230907174633) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-propagation-metadata-20230907174633"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/mdx"�[39m at �[32m"0.0.0-propagation-metadata-20230907174633"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/solid-js"�[39m at �[32m"0.0.0-propagation-metadata-20230907174633"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/markdown-remark"�[39m at �[32m"0.0.0-propagation-metadata-20230907174633"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-propagation-metadata-20230907174633 🦋 @astrojs/mdx@0.0.0-propagation-metadata-20230907174633 🦋 @astrojs/solid-js@0.0.0-propagation-metadata-20230907174633 🦋 @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907174633 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-propagation-metadata-20230907174633 🦋 New tag: @astrojs/mdx@0.0.0-propagation-metadata-20230907174633 🦋 New tag: @astrojs/solid-js@0.0.0-propagation-metadata-20230907174633 🦋 New tag: @astrojs/markdown-remark@0.0.0-propagation-metadata-20230907174633

@matthewp matthewp marked this pull request as ready for review September 7, 2023 17:58
@matthewp matthewp marked this pull request as draft September 7, 2023 18:00
@matthewp matthewp marked this pull request as ready for review September 7, 2023 18:01
@lilnasy
Copy link
Contributor

lilnasy commented Sep 7, 2023

It does not seem to fix #7761.

@matthewp
Copy link
Contributor Author

matthewp commented Sep 7, 2023

@lilnasy thanks, removing that one from the list. Once I made the change to the compiler, this really only targets VT issues. That one might be similar, however.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the compiler update!

@matthewp matthewp merged commit 7eea37a into main Sep 8, 2023
13 checks passed
@matthewp matthewp deleted the fix-layered-head-prop branch September 8, 2023 14:00
@astrobot-houston astrobot-houston mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
4 participants