From c8e603a8ef06e9863cd4f5a4226504142ef92489 Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Mon, 22 Jan 2024 15:51:47 +0000 Subject: [PATCH 1/2] fix: add missing attribute to button --- .changeset/lazy-fireants-clap.md | 5 +++++ packages/astro/astro-jsx.d.ts | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/lazy-fireants-clap.md diff --git a/.changeset/lazy-fireants-clap.md b/.changeset/lazy-fireants-clap.md new file mode 100644 index 000000000000..27d3b1130848 --- /dev/null +++ b/.changeset/lazy-fireants-clap.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Adds `popovertarget" to the attribute that can be passed to the `button` element diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index f79c5a36544a..72ba99b4ff5b 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -647,6 +647,7 @@ declare namespace astroHTML.JSX { name?: string | undefined | null; type?: 'submit' | 'reset' | 'button' | undefined | null; value?: string | string[] | number | undefined | null; + popovertarget?: string | undefined | null; } interface CanvasHTMLAttributes extends HTMLAttributes { From 43f8fb3e0c217ebaf67bc917849962db0023958a Mon Sep 17 00:00:00 2001 From: Emanuele Stoppa Date: Mon, 22 Jan 2024 17:08:54 +0000 Subject: [PATCH 2/2] feedback --- packages/astro/astro-jsx.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts index 72ba99b4ff5b..accd9002532c 100644 --- a/packages/astro/astro-jsx.d.ts +++ b/packages/astro/astro-jsx.d.ts @@ -812,6 +812,7 @@ declare namespace astroHTML.JSX { type?: HTMLInputTypeAttribute | undefined | null; value?: string | string[] | number | undefined | null; width?: number | string | undefined | null; + popovertarget?: string | undefined | null; } interface KeygenHTMLAttributes extends HTMLAttributes {