Skip to content

Conversation

@delucis
Copy link
Member

@delucis delucis commented Nov 25, 2025

Description (required)

This PR documents sanitizing user input if passing it to the navigate() API exported from the astro:transitions module. This is the same advice as required when using user input with the web standard navigation.navigate() method.

Shout out to @zomaxsec for highlighting this!

@delucis delucis added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Nov 25, 2025
@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 6da58c4
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6926fa3987abba0008291f11
😎 Deploy Preview https://deploy-preview-12791--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 25, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/view-transitions.mdx Source changed, localizations will be marked as outdated.
en/reference/modules/astro-transitions.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I did have a couple of suggestions for some more direct language for your consideration, but this looks like a wonderful docs addition! 🥳

delucis and others added 2 commits November 25, 2025 16:59
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your proposed suggestion, and LGTM! Thanks for making everyone safer, Chris!

@delucis delucis merged commit 178ffbd into main Nov 26, 2025
9 of 10 checks passed
@delucis delucis deleted the chris/navigate-docs branch November 26, 2025 13:11
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants