Update integration docs #3292
Update integration docs #3292
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Removed the types section. |
| @@ -330,7 +330,7 @@ The address, family and port number supplied by the [NodeJS Net module](https:// | |||
| **Why:** To access generated routes and assets for extension (ex. copy content into the generated `/assets` directory). If you plan to transform generated assets, we recommend exploring the [Vite Plugin API](https://vitejs.dev/guide/api-plugin.html) and [configuring via `astro:config:setup`](#updateconfig-option) instead. | |||
|
|
|||
| ```js | |||
| 'astro:build:done'?: (options: { dir: URL; routes: RouteData[] }) => void | Promise<void>; | |||
| 'astro:build:done'?: (options: { dir: URL; routes: RouteData[], pages: PageData[] }) => void | Promise<void>; | |||
There was a problem hiding this comment.
pages here should probably be typed as { pathname: string }>[] here to match Astro's types, but it'd be a great idea for us to add a PageData type into Astro's type definitions to make this more future proof!
There was a problem hiding this comment.
Ah yep, I missed this when removing the types. I'll fix this in a sec!
sarah11918
added
the
improve documentation
|
Alright, then let's do this thing! 🥳 |
What kind of changes does this PR include?
Description
pagesparam. Seems this was removed previously aspageswas due to be deprecated, but never was.routesalso currently has some limitations, sopagesis still useful for the time being.routesmetadata being empty in SSR because that doesn't appear to be true (example).