Skip to content

i18n(ja): Fix code mistakes in guides/cms/contentful.mdx #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yanthomasdev merged 4 commits into from
May 24, 2023
Merged

i18n(ja): Fix code mistakes in guides/cms/contentful.mdx #3321

yanthomasdev merged 4 commits into from
May 24, 2023

Conversation

@oki07
Copy link
Contributor

@oki07 oki07 commented May 23, 2023

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

  • What does this PR change? Give us a brief description.
    • Fix code mistakes (copied and pasted from the English version to ensure accurate fixes)

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4c24c05
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/646e5d6bb6cb2c0008ce2da5
😎 Deploy Preview https://deploy-preview-3321--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 23, 2023
morinokami
morinokami approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語版と同様のコードに修正されていることを確認しました、ありがとうございます！

LGTM👍

@yanthomasdev
Copy link
Member

yanthomasdev commented May 23, 2023

Thanks @ot07! I saw the PR fixing the interface references in the English page, could you see if there are any missing of these updates here, so we can merge with everything corrected? Thanks in advance!
#3324

@oki07
Copy link
Contributor Author

oki07 commented May 24, 2023

@Yan-Thomas
I apologize for overlooking the modifications in the English version of the same document. Upon reviewing #3324, it seems that there are updates in this PR that haven't been incorporated yet. I plan to commit those changes as well, albeit with a slight delay.

@oki07
Copy link
Contributor Author

oki07 commented May 24, 2023

@Yan-Thomas
I have incorporated the updates from the English version into this PR!

yanthomasdev
yanthomasdev approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work @ot07 💜

@yanthomasdev yanthomasdev merged commit 19ef9fe into withastro:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morinokami morinokami morinokami approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oki07 @yanthomasdev @morinokami