Clarify the use of the base parameter for deployment to GitHub Pages #5131
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
added
improve documentation
There was a problem hiding this comment.
This looks great, thank you so much for jumping on this issue! 🙌
I just shortened it by making it all one list, since reading the issue I don't think there's anything special about the one case? I think they can all go in the list?
And, since we're no longer talking about just the name of the repo, but its full URL, I think saying it's "located at" now makes more contextual sense in that point.
GitHub suggests are stupid when there's a deleted line, so it was unfortunately easier for me just to edit the page (which requires me to commit back directly) rather than make a suggestion for you to commit. Sorry, I normally prefer to just make a suggestion and let the author commit themselves!
So, I've just made the change, added the Hacktoberfest label, and when the tests pass and the preview checks out, I'll just merge straight away! 🙌
Description (required)
This PR is responsible for clarifying the instructions for when to use the base parameter when deploying astro applications to GitHub pages.
I referenced to the solution suggested in this comment of the issue
Updated changes
I am taking part in hacktoberfest 👍
Related issues & labels (optional)
Your repository is named <YOUR_USERNAME>.github.io.#4569https://deploy-preview-5131--astro-docs-2.netlify.app/en/guides/deploy/github/