Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade tailwind #10

Merged
merged 2 commits into from Mar 29, 2023
Merged

upgrade tailwind #10

merged 2 commits into from Mar 29, 2023

Conversation

itsMapleLeaf
Copy link
Contributor

@itsMapleLeaf itsMapleLeaf commented Mar 28, 2023

line clamp is now built in! as well as other goodies like logical properties https://tailwindcss.com/blog/tailwindcss-v3-3

also bumped the major, tailwind is now a peer dep which is technically breaking

Copy link
Collaborator

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great to see logical props added to Tailwind! If I remember right it's only block- for now, but that goes a long way towards easier internationalization!

"typescript": "^5.0.2"
},
"peerDependencies": {
"eslint": ">=8"
"eslint": ">=8",
"tailwindcss": ">=3.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm has made me never trust peer dependencies 😅 This should work fine but keep an eye out for weird CI build issues if pnpm in Netlify builds doesn't pick this up right

@tony-sull
Copy link
Collaborator

strange test failure there 🤔 I'm fine if you ignore that here for now, I'm actually working on a branch to clean up old experimental components and revisiting the test setup

@itsMapleLeaf itsMapleLeaf merged commit 6417ce1 into main Mar 29, 2023
1 of 2 checks passed
@itsMapleLeaf itsMapleLeaf deleted the upgrade-tailwind branch March 29, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants