New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messages for Eve server #553

Merged
merged 3 commits into from Nov 15, 2016

Conversation

Projects
None yet
3 participants
@cmontella
Contributor

cmontella commented Nov 14, 2016

Displays a better message when the server stops, and a better error when the server cannot start due to the port being in use.

@ibdknox
Contributor

ibdknox left a comment

We have to do the PORT environment variable to work on Heroku and the like, but maybe we should consider adding a --port 8080 cli argument as well?

// If the port is already in use, display an error message
process.on('uncaughtException', function(err) {
if(err.errno === 'EADDRINUSE') {
console.log(`ERROR: Eve couldn't start because port ${PORT} is already in use. Close the process using this port and try again.`);

This comment has been minimized.

@ibdknox

ibdknox Nov 15, 2016

Contributor

Instead of telling them to close the thing on that port, we could tell them to use the PORT env variable to use a different port.

@cmontella cmontella merged commit d400d32 into master Nov 15, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@cmontella cmontella deleted the corey branch Nov 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment