Remove unnecessary condition in fullScan #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two reasons to remove this condition.
It's not used. All conditions when
attribute
is present arealready coverered via index lookup in other branches of switch in
getProposal
(
*a**
,ea**
,*av**
,eav*
,***n
).It's broken. Default branch of switch (which corresponds to full scan) in
getProposal
always populatesproviding
in order of EAV, but if thiscondition would ever run it would return values in order of AVE thus
breaking the assumptions of
joinRound
function.This change is