New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determining if a stratum has database scans #614

Merged
merged 1 commit into from Nov 30, 2016

Conversation

Projects
None yet
2 participants
@ibdknox
Copy link
Contributor

ibdknox commented Nov 30, 2016

Ifs and nots can technically use only local variables and don't necessarily mean we have database scans. The practical implication of this is that any block that had an if or not in it always reran when evaling. This prevents purely static blocks from doing so.

@convolvatron
Copy link
Contributor

convolvatron left a comment

ok, so this was misclassifying blocks with scans hidden inside sub blocks as one-shot initializers...isnt that a big deal?

@ibdknox

This comment has been minimized.

Copy link
Contributor Author

ibdknox commented Nov 30, 2016

Other way around. The old code was conservatively saying that anything with an if/not was definitely not a one-shot block. Now the code recursively checks inside if/not to see if they're actually static too. If everything is static, including the bodies of the ifs/nots, then we can treat the block as single run.

@ibdknox ibdknox merged commit 9afe634 into master Nov 30, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@cmontella cmontella deleted the has-database-scans branch Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment