Fix/horrible perf #731

Merged
merged 4 commits into from Jan 11, 2017

Projects

None yet

2 participants

@joshuafcole
Contributor
joshuafcole commented Jan 11, 2017 edited

This helps extend the size ceiling on documents in the editor temporarily by memoizing the function which contains the majority of the expensive calls. Since it's called in 2-3 separate occasions this improves performance enough to be workable again.

I'm currently stress-testing it to ensure there aren't situations where stale values may get used, but that shouldn't be possible so long as all doc changes flow through CMs change pipeline.

Slightly longer term, the right solution to this problem is either incremental parsing or dropping the text mapping phase and exchange something less expensive to compute.

@joshuafcole joshuafcole requested a review from ibdknox Jan 11, 2017
@ibdknox

👍

@ibdknox ibdknox merged commit 3349a80 into master Jan 11, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment