Add a custom error message for values without attributes in a record#845
Merged
joshuafcole merged 1 commit intoJun 16, 2017
Merged
Conversation
joshuafcole
approved these changes
Jun 16, 2017
Contributor
joshuafcole
left a comment
There was a problem hiding this comment.
Thanks for the help, looks great!
|
I'm working on the other part of this, but how do I test it out? Is there a way to get the eve-starter to run my modified code? |
Contributor
|
Hey @ChristopherDumas, You can then start this locally build version using |
|
Awesome, thanks.
On Mon, Aug 28, 2017 at 5:41 PM Joshua Cole ***@***.***> wrote:
Hey @ChristopherDumas <https://github.com/christopherdumas>,
You should be able to build eve from source code by running npm install
&& npm run build within the eve repository assuming you have a relatively
recent version of NodeJS and NPM installed.
You can then start this locally build version using npm start.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#845 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1Ml1602Nn5rvB2-wJ5XDJVv45ww_v0ks5sc14dgaJpZM4N69qZ>
.
--
Regards,
Christopher
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements part of the feature request in #436. It adds a slightly friendlier error message that appears when a value without an attribute in a record. For example, this code
will generate the error message
"-20" needs to be labeled with an attribute.After this, the
attributerule could be modified to take another argument specifying whether the record that is being parsed is part of afunctionRecord. If so, the message could mention that function syntax requires arguments to be labeled, and include parameter names if it is a standard library function. I can work on that next, if this looks good to you.