New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix to delegate svg/root to the html watcher like canvas #846

Merged
merged 2 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@joshuafcole
Contributor

joshuafcole commented Jun 16, 2017

  • Enables using html.addExternalRoot() to control SVG placement
  • Enables mixing SVG into html documents, a feature I'd embarrassingly forgotten that the previous SVG library lacked.
  • This fix is robust, but the original DOM library abstraction is really creaking here, it's worth revisiting in the future. This is especially the case since UI performance can be easily improved by an order of magnitude or more by not mirroring the instances back into Eve. In 0.4, this isn't really an issue, but 0.3 could really benefit from the boost.

@joshuafcole joshuafcole requested a review from cmontella Jun 16, 2017

@ibdknox

👍

@joshuafcole joshuafcole merged commit 7069e77 into master Jun 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment