Skip to content

quickfix to delegate svg/root to the html watcher like canvas#846

Merged
joshuafcole merged 2 commits into
masterfrom
fix/svg-root-delegation
Jun 16, 2017
Merged

quickfix to delegate svg/root to the html watcher like canvas#846
joshuafcole merged 2 commits into
masterfrom
fix/svg-root-delegation

Conversation

@joshuafcole

Copy link
Copy Markdown
Contributor
  • Enables using html.addExternalRoot() to control SVG placement
  • Enables mixing SVG into html documents, a feature I'd embarrassingly forgotten that the previous SVG library lacked.
  • This fix is robust, but the original DOM library abstraction is really creaking here, it's worth revisiting in the future. This is especially the case since UI performance can be easily improved by an order of magnitude or more by not mirroring the instances back into Eve. In 0.4, this isn't really an issue, but 0.3 could really benefit from the boost.

@ibdknox ibdknox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshuafcole joshuafcole merged commit 7069e77 into master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants