New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for non-fixpoint #847

Merged
merged 5 commits into from Jun 16, 2017

Conversation

Projects
None yet
2 participants
@cmontella
Contributor

cmontella commented Jun 16, 2017

No description provided.

Show outdated Hide outdated src/runtime/runtime.ts
console.error("bad");
break;
if (total > iterationLimit) {
console.error(`Failed to fixpoint after ${iterationLimit} iterations`);

This comment has been minimized.

@joshuafcole

joshuafcole Jun 16, 2017

Contributor

Let's word this such that it's more obvious the program is at fault. Maybe Error: Program failed to fixpoint after ${iterationLimit} iterations. This is likely due to an unbounded cycle in the program. or something. Other than that, looks fine.

@joshuafcole

joshuafcole Jun 16, 2017

Contributor

Let's word this such that it's more obvious the program is at fault. Maybe Error: Program failed to fixpoint after ${iterationLimit} iterations. This is likely due to an unbounded cycle in the program. or something. Other than that, looks fine.

This comment has been minimized.

@joshuafcole

joshuafcole Jun 16, 2017

Contributor

Let's not add those spaces after keywords like if and while though, we aren't doing that elsewhere.

@joshuafcole

joshuafcole Jun 16, 2017

Contributor

Let's not add those spaces after keywords like if and while though, we aren't doing that elsewhere.

@joshuafcole

👍

@joshuafcole joshuafcole merged commit 9c70e42 into master Jun 16, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment