Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for non-fixpoint #847

Merged
merged 5 commits into from Jun 16, 2017
Merged

Conversation

cmontella
Copy link
Contributor

@cmontella cmontella commented Jun 16, 2017

No description provided.

console.error("bad");
break;
if (total > iterationLimit) {
console.error(`Failed to fixpoint after ${iterationLimit} iterations`);
Copy link
Contributor

@joshuafcole joshuafcole Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's word this such that it's more obvious the program is at fault. Maybe Error: Program failed to fixpoint after ${iterationLimit} iterations. This is likely due to an unbounded cycle in the program. or something. Other than that, looks fine.

Copy link
Contributor

@joshuafcole joshuafcole Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not add those spaces after keywords like if and while though, we aren't doing that elsewhere.

Copy link
Contributor

@joshuafcole joshuafcole left a comment

👍

@joshuafcole joshuafcole merged commit 9c70e42 into master Jun 16, 2017
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants