Skip to content

Prevent exception from program which parses to no code blocks#850

Merged
joshuafcole merged 1 commit into
witheve:masterfrom
btheado:fix/program-load-empty
Jun 20, 2017
Merged

Prevent exception from program which parses to no code blocks#850
joshuafcole merged 1 commit into
witheve:masterfrom
btheado:fix/program-load-empty

Conversation

@btheado
Copy link
Copy Markdown
Contributor

@btheado btheado commented Jun 20, 2017

Program.inputEAVs throws an exception when the input eav array is empty, so Program.load shouldn't call it when no code blocks are returned from parsing the document.

Copy link
Copy Markdown
Contributor

@cmontella cmontella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me

Copy link
Copy Markdown
Contributor

@joshuafcole joshuafcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch, thanks!

@joshuafcole joshuafcole merged commit b450df3 into witheve:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants