Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pscale completion spec #665

Merged
merged 3 commits into from
Oct 15, 2021
Merged

feat: add pscale completion spec #665

merged 3 commits into from
Oct 15, 2021

Conversation

gusfune
Copy link
Contributor

@gusfune gusfune commented Oct 13, 2021

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds PlanetScale CLI specs as requested on #661. (Closes #661)

@withfig-bot
Copy link
Collaborator

Overview

src/pscale.ts:

Info:

URLs:

  • https://api.planetscale.com/

@withfig-bot
Copy link
Collaborator

Hello @gusfune,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments have the arg property (arg: {})?
  • Are all options modular? E.g. a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Love PlanetScale, they are doing an amazing job!

src/pscale.ts Show resolved Hide resolved
src/pscale.ts Outdated Show resolved Hide resolved
src/pscale.ts Outdated Show resolved Hide resolved
src/pscale.ts Outdated Show resolved Hide resolved
src/pscale.ts Outdated Show resolved Hide resolved
@gusfune gusfune requested a review from QuiiBz October 15, 2021 04:02
@gusfune
Copy link
Contributor Author

gusfune commented Oct 15, 2021

Finished with all change requests by @QuiiBz. Those were very helpful, thanks!

Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome, you've done a really great job! LGTM 🎉

@QuiiBz QuiiBz merged commit f01e820 into withfig:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pscale] CLI
3 participants