This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Mobile misc cleanup #3287
Merged
Mobile misc cleanup #3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
brianlovin
approved these changes
Jun 11, 2018
Contributor
brianlovin
left a comment
brianlovin
left a comment
There was a problem hiding this comment.
This looks good to me - I think 'Loading {entity}...' feels a bit awkward in practice, and maybe it can just be left blank or we put some kind of loading indicator there?
Not high pri, but I'll look into it as we polish. Regardless, everything else looks good here :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
srctoshared