Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default alt text to img #4887

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@aszx87410
Copy link
Contributor

commented Mar 21, 2019

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

Related issues (delete if you don't know of any)
Closes #4812

When user uploads the image, the system already automatically set image alt by file name. But for some edge cases there might not have alt text and we need to set a default value, otherwise it breaks the layout. You can find more details on the issue: Weird image failed rendering in thread body

Before:
螢幕快照 2019-03-21 下午9 45 37

After:
螢幕快照 2019-03-21 下午9 45 56

@brianlovin brianlovin merged commit 26aac9a into withspectrum:alpha Mar 21, 2019

6 checks passed

ci/circleci: build_web Your tests passed on CircleCI!
Details
ci/circleci: checkout_environment Your tests passed on CircleCI!
Details
ci/circleci: test_e2e Your tests passed on CircleCI!
Details
ci/circleci: test_e2e_external Your tests passed on CircleCI!
Details
ci/circleci: test_static_js Your tests passed on CircleCI!
Details
ci/circleci: test_unit Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.