Dmitri Dolguikh witlessbird

Organizations

@apps4good @theforeman
witlessbird commented on pull request theforeman/smart-proxy#277
@witlessbird

git rebase -i HEAD~4 should do the trick. You'll be given a choice which commits to squash, which is all but one (the last one is my usual pick). Y…

witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

@claer, @mchesler: is this good to merge, or are there still issues remaining?

witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

@claer: removed extraneous "--service" when registering windows service.

@witlessbird
  • @mmatuska 054ce13
    Fixes #9713: restore WIN32 service support
witlessbird commented on pull request theforeman/smart-proxy#280
@witlessbird

[test]

witlessbird commented on pull request theforeman/smart-proxy#272
@witlessbird

@lzap: now prints out migrations as they are being executed.

@witlessbird
  • @witlessbird 4fe68d8
    Fixes #10003: Support for config file migrations
witlessbird commented on pull request theforeman/smart-proxy#272
@witlessbird

re: migrations state file -- it's only being read, but not written to. This is the same as the rest of migrations -- the final results will be loca…

witlessbird commented on pull request theforeman/smart-proxy#272
@witlessbird

Hmm. Not sure, tbh. I feel that if the state file doesn't exist at the specified (or default) location, the user should be notified -- could be a w…

witlessbird commented on pull request theforeman/smart-proxy#272
@witlessbird

Hmm, I think the default location is sensible? I could add an empty migration state there though...

witlessbird commented on pull request theforeman/smart-proxy#281
@witlessbird

[test]

witlessbird commented on pull request theforeman/smart-proxy#281
@witlessbird

@claer: could you test this?

witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

@mchesler: should do the trick...

@witlessbird
  • @mmatuska cda30a8
    Fixes #9713: restore WIN32 service support
witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

[test]

witlessbird commented on pull request theforeman/smart-proxy#272
@witlessbird

@lzap: fixed the issue you pointed out!

@witlessbird
  • @witlessbird eb0b3a5
    Fixes #10003: Support for config file migrations
witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

or you can post it in the redmine ticket.

witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

@claer, @mchesler: if you have a backtrace, could you post it here?

witlessbird commented on pull request theforeman/smart-proxy#274
@witlessbird

@claer: done and done.

@witlessbird
  • @mmatuska e37dc53
    Fixes #9713: restore WIN32 service support
witlessbird commented on pull request OpenSCAP/smart_proxy_openscap#10
@witlessbird

Should be Proxy:: FileLock::try_locking, not Proxy::HttpDownloads.try_locking

witlessbird commented on pull request OpenSCAP/smart_proxy_openscap#10
@witlessbird

Proxy:: FileLock::try_locking will create a lock file when needed.

witlessbird commented on pull request OpenSCAP/smart_proxy_openscap#10
@witlessbird

looks good, except for the issue around lock release I pointed out.

witlessbird commented on pull request OpenSCAP/smart_proxy_openscap#10
@witlessbird

You should release the lock in ensure block, it will stick around should file creation fail.

witlessbird commented on pull request theforeman/foreman#2331
@witlessbird

@eLobato: tests passed (was a false negative the first time).

witlessbird commented on pull request theforeman/foreman#2331
@witlessbird

[test]

witlessbird commented on pull request theforeman/foreman#2331
@witlessbird

More of a hint, really, that SHA256 is default/preferred.

witlessbird commented on pull request theforeman/smart-proxy#280
@witlessbird

Yeah, that's it. It would be pretty great if you could update the test here https://github.com/theforeman/smart-proxy/blob/develop/test/dhcp/dhcp_c…

witlessbird commented on pull request theforeman/smart-proxy#280
@witlessbird

I'd add a default value here: https://github.com/theforeman/smart-proxy/blob/develop/modules/dhcp/dhcp_plugin.rb#L5. Safety checks will no longer b…