Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discoverable also for home-assistant.io #8

Merged
merged 2 commits into from May 30, 2017

Conversation

selvakn
Copy link

@selvakn selvakn commented May 3, 2017

cc: @dhivyada

@@ -9,7 +9,7 @@ WemoSwitch::WemoSwitch(){
}
//WemoSwitch::WemoSwitch(String alexaInvokeName,unsigned int port){
WemoSwitch::WemoSwitch(String alexaInvokeName, unsigned int port, CallbackFunction oncb, CallbackFunction offcb){
uint32_t chipId = ESP.getChipId();
uint32_t chipId = ESP.getChipId() + port;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment but I would change the variable name to reflect its the chipIdWithPort

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@witnessmenow
Copy link
Owner

Looks good, thanks for the PR. Have you tested that it still works with Alexa after the changes?

I can test it over the weekend if you haven't got a chance

@selvakn
Copy link
Author

selvakn commented May 4, 2017

You are welcome!
I have tested this with alexa and home-assistant.io, for single and multiple switches.

@witnessmenow witnessmenow merged commit 0e3213a into witnessmenow:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants