Add unit-tests for the primary-secondary realms #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
force-pushed
the
pri-sec-context-unittest
branch
3 times, most recently
from
14adaa8
to
4c7f4e9
Compare
d4vidi
changed the title
d4vidi
force-pushed
the
pri-sec-context-unittest
branch
2 times, most recently
from
cb8b6d0
to
df0bd13
Compare
noomorph
force-pushed
the
pri-sec-context-unittest
branch
from
3b9c6e0
to
3131ab5
Compare
noomorph
approved these changes
Nov 17, 2022
d4vidi
commented
Nov 17, 2022
|
So looks like we're just 1 subtle iteration away from merging. Will you able to get on it tomorrow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have add some unit-test coverage over the primary-context element. More to come*.
* secondary context, among other things. Also, logger initialization, worker initialization.