Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Accessibility font scaling on iOS #831

Open
Simek opened this issue May 28, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Simek
Copy link

commented May 28, 2019

Description

On iOS user can decide about globally Text Size multiplayer using Accessibility setting.
https://facebook.github.io/react-native/docs/text#allowfontscaling

Currently system font scaling is ignored in react-native-calendars library - most of components have property allowFontScaling={false} added.

Expected Behavior

Component text scale with Accessibility setting.

Observed Behavior

No changes in Text size when Accessibility scale is used.

Environment

  React Native Environment Info:
    System:
      OS: macOS 10.14.4
      CPU: x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
      Memory: 326.38 MB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 11.11.0 - /usr/local/bin/node
      Yarn: 1.15.2 - /usr/local/bin/yarn
      npm: 6.9.0 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
    IDEs:
      Android Studio: 3.4 AI-183.6156.11.34.5522156
      Xcode: 10.2/10E125 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.8.6 => 16.8.6 
      react-native: 0.59.8 => 0.59.8 
@Simek

This comment has been minimized.

Copy link
Author

commented May 28, 2019

Are there any internal issues when font scaling is turned on or just UI glitches?

@ethanshar @Inbal-Tish I'll want to start working on PR for this feature if there are no known contraindications.

@Inbal-Tish

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

@Simek As far as I can tell there are only UI issues, but it is worth further checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.