Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity lifecycle send DidAppear & Disappear #7177

Merged
merged 1 commit into from Jul 7, 2021

Conversation

swabbass
Copy link
Contributor

@swabbass swabbass commented Jul 7, 2021

Issue:

When the app switches to BG or a new activity is opened, appearance events did not get sent to the RN side, since it's logical to have them sent when the app is not visible, which means every visible component now is invisible, and vice versa.

Fix:

Support sending DidAppear/Disappear events when activity changes visibility state, OnPause & OnResume.

Closes: #7158

@swabbass swabbass added this to Selected for Development in React Native Navigation Jul 7, 2021
@swabbass swabbass marked this pull request as ready for review July 7, 2021 11:22
@swabbass swabbass requested a review from yogevbd July 7, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

ComponentDidAppear and ComponentDidDisappear is not called when open another native Android activity
2 participants