Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): invalid node location offset #2897

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Aug 30, 2023

Similar to the off-by-one fix in postcss, this PR fixes the offset of invalid nodes.

There is another bug in postcss root source location relating to the column, but we don't use it for anything, so I just left the comment and might create a fix for them at some other time.

@idoros idoros added bug Unexpected behavior or exception language-service Completions, highlights, definitions and more LSP capabilities labels Aug 30, 2023
@idoros idoros self-assigned this Aug 30, 2023
@idoros idoros requested a review from barak007 August 30, 2023 09:50
@idoros idoros merged commit 8e915dd into master Sep 10, 2023
18 checks passed
@idoros idoros deleted the ido/fix-safe-parse-invalid-node-offset branch September 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or exception language-service Completions, highlights, definitions and more LSP capabilities
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant