Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Secure attribute in a Property fails to build merge module in 3.6, when a Custom Action from a .dll is defined #3795

Open
wixbot opened this issue Oct 4, 2012 · 5 comments
Labels
Milestone

Comments

@wixbot
Copy link

wixbot commented Oct 4, 2012

This use case emerged when I updated from 3.5 to 3.6 (which will affect 3.7 as well I guess). It was working in 3.5, but not in the newer version. Having custom actions declared and setting some properties as secure, causes an error and the build of the merge module fails. The custom action is accessing a method in a dll.
The error that i get is:
error LGHT0136: There was an error importing table 'Property' from file 'C:........\Local\Temp\lpikpxrr\Property.idt'
the file in my case that was reported contained the following:
Property Value
s72 l0
Property Property
ALLUSERS 1
DELETEORPHANEDFILES 1
CONNECTORWINDOWSSERVICENAME.879D8938_14F7_4C42_910E_C588197F88F1 Formicary Chat Connector Service
CONNECTORWINDOWSSERVICEDISPLAYNAME.879D8938_14F7_4C42_910E_C588197F88F1 Formicary Connector Service
CONNECTORWINDOWSSERVICEDESCRIPTION.879D8938_14F7_4C42_910E_C588197F88F1 Formicary Connector Service
EVENTLOGNAME.879D8938_14F7_4C42_910E_C588197F88F1 Application
CONNECTOREVENTLOGSOURCE.879D8938_14F7_4C42_910E_C588197F88F1 Connector Server
SecureCustomProperties WINDOWSPASSWORD
MsiHiddenProperties

An example that replicates this is the following:

<Directory Id="TARGETDIR" Name="SourceDir">
  <Directory Id="ProgramFiles64Folder">
    <Directory Id="INSTALLDIR" Name="Foo">
      <Component Id="cmp1" Guid="{6102D687-A7E8-475E-85FA-346EACE99C8A}">
        <File Id="testFile" KeyPath="yes" Checksum="yes" Source="C:\test.txt" />
      </Component>
    </Directory>
  </Directory>
</Directory>

<!--This fails. If i remove the Secure attribute, it will work-->
<Property Id="PROPERTY1" Value="1" Secure="yes"/>

<!--Custom Action Definitions. The Dll file, and the Custom action to call-->
<Binary Id="CustomActions" SourceFile="$(var.CustomAction.TargetDir)$(var.CustomAction.TargetName).CA.dll"/>
<!--THIS SEEMS TO BE THE PROBLEM. IF I REMOVE THE LINES BELOW, I CAN SET THE PROPERTY ABOVE AS SECURE. I dont even include the custom action in the install execute sequence-->
<CustomAction Id="DeleteOrphanedFiles" BinaryKey="CustomActions"
               DllEntry="DeleteUnusedFilesOrDirectoriesForConnector" Execute="deferred" Return="check" HideTarget="yes" Impersonate="no"/>

Originally opened by kyprous from http://sourceforge.net/p/wix/bugs/3108/

@wixbot
Copy link
Author

wixbot commented Nov 21, 2012

I got the same error after upgrading to 3.6. In my case the error is in a merge module but is not caused by a Custom action but by the PerformanceCategory extension.

@wixbot
Copy link
Author

wixbot commented Oct 22, 2013

Originally changed by barnson
Release changed from v3.8 to v3.x

@wixbot wixbot added the bug label Dec 20, 2015
@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@JFReni
Copy link

JFReni commented Jul 21, 2017

After upgrading from Wix 3.10 to Wix 3.11 this bug has resurfaced. Can be seen when attempting to use the <util:XmlFile> or <util:XmlConfig> tags in a merge module that also references secure properties, such as those in the WixNetFxExtension.

@remkm01
Copy link

remkm01 commented Jul 22, 2017

I was able to reproduce the issue as well after upgrading to Wix 3.11 (3.11.0.1701). When building the merge module, I get the following error:

error LGHT0136: There was an error importing table 'Property' from file '\Property.idt'.

@remkm01
Copy link

remkm01 commented Jul 22, 2017

Update... I added my own registry search instead of using the NetFxExtension and I got the same error. I was able to get past the error by making the property hidden.

<Property Id="NETFRAMEWORK40FULLINSTALLROOTDIR" Secure="yes" Hidden ="yes">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants