Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Engine.VersionVariables #3951

Closed
wixbot opened this Issue Mar 18, 2013 · 4 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Mar 18, 2013

Setter doesn't accept Version instances having no build and/or revision specified (unspecified fields are set to -1 according to MSDN).
For instance, when trying to set version variable with unspecified revision bootstrapper fails with OverflowException.
I have installed product for which MsiGetProductInfo(...INSTALLPROPERTY_VERSIONSTRING...) returns three-component version string:
Engine.VersionVariables["variableName"] = Version.Parse(versionString)
Shouldn't Engine.VersionVariables documentation indicate that unspecified fields in Version are unsupported? Or probably method should throw ArgumentException in such case? Or treat unspecified fields as 0?

Originally opened by zepilot from http://sourceforge.net/p/wix/bugs/3249/

Collaborator

wixbot commented Oct 8, 2013

Originally changed by barnson
Area set to extensions
Release changed from v3.8 to v3.x

Collaborator

wixbot commented May 29, 2014

Originally changed by rseanhall
AssignedTo set to shall

Collaborator

wixbot commented May 29, 2014

Pull request - wixtoolset/wix3#53

Originally posted by rseanhall
Release changed from v3.x to v3.9

Collaborator

wixbot commented Jun 2, 2014

Pull request merged.

Originally posted by rseanhall
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.9 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment