Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

pyro ArgumentOutOfRangeException in PatchAPIMarshaller.CreateArrayOfStringA #4036

Closed
wixbot opened this Issue Jun 19, 2013 · 5 comments

Comments

Projects
None yet
1 participant
Collaborator

wixbot commented Jun 19, 2013

If a patch is to be generated which could be applied on two versions in conjunction with the option -delta an ArgumentOutOfRangeException is thrown in the method "CreateArrayOfStringA" - but only if this involves two files with different "patch situations".

For example file "A" different in version of 1.0.0 (==RTM), 1.0.1 (==Patch1) and 1.0.2 (target version) and a file "B" only different in 1.0.0 and 1.0.1 but identical to 1.0.1 in the target version 1.0.2.

My impression is that perhaps the PatchAPIMarshaller might be reusing an obselete value in its member "oldFileCount" and that maybe just the check in line 700

this.oldFileCount != managed.Length

is superfluous - especially as the next line of code is:

this.oldFileCount = managed.Length;

I have created a small example for reproduction (see attachment).

Originally opened by timoffermann from http://sourceforge.net/p/wix/bugs/3324/

Collaborator

wixbot commented Jul 14, 2013

This code is my code. I'm looking at this repro now

Collaborator

wixbot commented Sep 18, 2013

Triage: Please resolve this as fixed. It was fixed with commit: 6e3a1b67087d back in July.

Originally posted by bmurri

Collaborator

wixbot commented Sep 19, 2013

I have retested my original problem with version 3.8.826 and it worked like a charm. Thank you all for taking care! Tim Offermann

Originally posted by toffer

Collaborator

wixbot commented Sep 19, 2013

Originally changed by bmurri
AssignedTo set to wixsupport

Collaborator

wixbot commented Sep 19, 2013

Originally changed by bmurri
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added the bug label Dec 20, 2015

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment