New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null Reference exception in Unbinder:UnbindTransform processing MSPs #4057

Closed
wixbot opened this Issue Jul 12, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@wixbot
Collaborator

wixbot commented Jul 12, 2013

Line 1257-1259 of Unbinder.cs in current 3.8 release:
else if ("INSERT" == columnName) // added row
{
string index = String.Concat(tableName, ':', primaryKeys);

I had a primaryKey value of:
"{A00D7E9D-5A00-4F7A-83BA-AC2F85B6F3C4}\t7.5.1525.0\t \t \t1282"

Value of key in rows[] was without spaces after embedded tabs:
"{A00D7E9D-5A00-4F7A-83BA-AC2F85B6F3C4}\t7.5.1525.0\t\t\t1282"

Suggest that this should be similar form to:
string index = String.Concat(tableName, ':', primaryKeys.Replace(" ", ""))

Of course all rows[] operations do not check for invalid index value.

Originally opened by msainsbury from http://sourceforge.net/p/wix/bugs/3342/

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Sep 18, 2013

Triage: Please resolve this as fixed. It was fixed with commits: 2ca9ecfe61f8, e3230157a224 back in July.

Originally posted by bmurri

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Sep 19, 2013

Originally changed by bmurri
AssignedTo set to wixsupport

@wixbot

This comment has been minimized.

Collaborator

wixbot commented Sep 19, 2013

Originally changed by bmurri
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added the bug label Dec 20, 2015

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment