Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call RtlGetVersion out of ntdll.dll to get OS version #4061

Closed
wixbot opened this issue Jul 19, 2013 · 7 comments
Closed

Call RtlGetVersion out of ntdll.dll to get OS version #4061

wixbot opened this issue Jul 19, 2013 · 7 comments
Milestone

Comments

@wixbot
Copy link
Collaborator

@wixbot wixbot commented Jul 19, 2013

GetVersion(Ex) requires that the EXE be manifested to declare explicit support for the OS on which it's installing. This may not be what people want. Instead, you can GetProcAddress() "RtlGetVersion" from ntdll.dll and get the OS version without requiring the EXE to be manifested.

Originally opened by heaths from http://sourceforge.net/p/wix/bugs/3345/

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Jul 25, 2013

Because we have to keep manifesting bundles just to support newer versions of Windows. It's a mundane task that can be avoided with RtlGetVersion. Besides, while it may be uncommon to require detecting for newer versions of an OS that haven't even shipped yet, some people may want to block on them because they haven't been tested. If Burn isn't manifested accordingly early enough, GetVersion(Ex) lies and the product that should block now gets installed on the newer OS that hasn't yet been tested.

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Jul 25, 2013

Why is this better than explicit manifesting or the IsWindows*OrGreater helpers?

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Aug 24, 2013

We have to continue to manifest the Burn stub so this change would be to get correct VersionNT[64] values for OSes before they're publicly released and the new compatibility guids are documented and added to the stub. So I'm fine with this change in v3.x if implementing it were to scratch someone's itch.

Originally posted by barnson
Release changed from v4.0 to v3.8

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Sep 18, 2013

Originally changed by bmurri
AssignedTo set to wixsupport

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Oct 24, 2013

Blair, any progress?

Originally posted by barnson
Area set to burn

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Oct 24, 2013

I believe I have this correctly scoped and I'll have a fix ready this weekend.

Originally posted by bmurri

@wixbot
Copy link
Collaborator Author

@wixbot wixbot commented Oct 28, 2013

Committed by barnson 9 hours ago. Commit d239a866a40b.

Originally posted by bmurri
Resolution set to fixed
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015
@wixbot wixbot closed this Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant