Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Source Zip File from Codeplex #4080

Closed
wixbot opened this Issue Aug 23, 2013 · 6 comments

Comments

Projects
None yet
2 participants
Collaborator

wixbot commented Aug 23, 2013

Quite a lot of people download the source zip and then start asking why it won't compile and the stock answer is that it is for reference. Now the code is on Codeplex you can download the code as a zip without the need to install Git and go through that learning curve.

Instead of the build process generating the zip could it interface to Codeplex and get the source zip from there? Alternatively should the release not include the source but document how to go to Codeplex and download it.

Originally opened by neilsl

Collaborator

wixbot commented Aug 25, 2013

It's an interesting thought. However, the source code needs to match the .pdbs so you'd actually need to get the code from Codeplex that matched a git tag exactly in order to debug successfully. I think we need the .zip files still for that case.

The source code as a .zip file from Codeplex might work for official releases since you can get the "latest zip file" per branch. However, the branches need to remain frozen after release for that to work (which is typically how it works but no exceptions would be allowed). But it would clean up the final releases.

Originally posted by robmen

Collaborator

wixbot commented Aug 29, 2013

Replace pdb and src zips with one "dev"/"debug" zip that includes both. Rationale: The pdbs and sources need to be in lock-step anyway and it prevents people from thinking that the src zip is buildable.

Originally posted by barnson
Area set to installer

Collaborator

wixbot commented Aug 29, 2013

My thought was that as part of the build the source was extracted from Codeplex as a zip so would match the pdbs that are generated. This source could also be built as it would be complete.

Bob - would your suggest allow someone to debug release code?

Originally posted by neilsl

Collaborator

wixbot commented Sep 5, 2013

The build machine has the exact sources used to generate the build, including pdbs, so I'm not sure what benefit there would be of also downloading it from Codeplex. Also, Codeplex doesn't seem to have a predictable URL pattern to point to a particular commit for downloading. We could point to the browse view of a particular commit and say "click Download" but not automate it.

The pdbs as-shipped work for debugging release code, as well as possible given optimizations. If that's not the case with v3.8, it's a bug.

Originally posted by barnson

Collaborator

wixbot commented Oct 7, 2013

This will be fixed in next build. There will be a new wix-debug.zip that replaces the pdbs/sources .zip files.

Originally posted by robmen
AssignedTo set to robmen
Resolution set to fixed

Collaborator

wixbot commented Oct 7, 2013

Originally changed by robmen
Status changed from Open to Resolved

@wixbot wixbot added this to the v3.8 milestone Dec 20, 2015

@wixbot wixbot closed this Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment